[Inference API] Fix model field in OpenAI Upgrade IT #119362
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxhniebergall
added
>test
|
Pinging @elastic/ml-core (Team:ML) |
maxhniebergall
added
the
auto-backport
prwhelan
approved these changes
Dec 30, 2024
maxhniebergall
added a commit
to maxhniebergall/elasticsearch
that referenced
this pull request
Dec 30, 2024
* Fix NPE by getting request once and defaulting to empty list * Fix error in OpenAIUpgrade test which used the wrong field name for certain versions * [CI] Auto commit changes from spotless --------- Co-authored-by: elasticsearchmachine <[email protected]>
maxhniebergall
added a commit
to maxhniebergall/elasticsearch
that referenced
this pull request
Dec 30, 2024
* Fix NPE by getting request once and defaulting to empty list * Fix error in OpenAIUpgrade test which used the wrong field name for certain versions * [CI] Auto commit changes from spotless --------- Co-authored-by: elasticsearchmachine <[email protected]>
elasticsearchmachine
pushed a commit
that referenced
this pull request
Dec 30, 2024
* Fix NPE by getting request once and defaulting to empty list * Fix error in OpenAIUpgrade test which used the wrong field name for certain versions * [CI] Auto commit changes from spotless --------- Co-authored-by: elasticsearchmachine <[email protected]>
elasticsearchmachine
pushed a commit
that referenced
this pull request
Dec 30, 2024
* Fix NPE by getting request once and defaulting to empty list * Fix error in OpenAIUpgrade test which used the wrong field name for certain versions * [CI] Auto commit changes from spotless --------- Co-authored-by: elasticsearchmachine <[email protected]>
sarog
pushed a commit
to portsbuild/elasticsearch
that referenced
this pull request
Jan 22, 2025
…elastic#119371) * Fix NPE by getting request once and defaulting to empty list * Fix error in OpenAIUpgrade test which used the wrong field name for certain versions * [CI] Auto commit changes from spotless --------- Co-authored-by: elasticsearchmachine <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #119028
It seems that before 8.13, in the OpenAI service, the model_id was available in task settings under the field name "model", but the field was incorrectly called "model_id" in the test.